Skip to content

Conversation

@lsviben
Copy link
Contributor

@lsviben lsviben commented Oct 14, 2025

Just fixed some line breaks.

@lsviben lsviben requested a review from jbw976 October 14, 2025 17:50
@netlify
Copy link

netlify bot commented Oct 14, 2025

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit 4ce6e48
🔍 Latest deploy log https://app.netlify.com/projects/crossplane/deploys/68ee8f4eff7a500007819a2d
😎 Deploy Preview https://deploy-preview-1007--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 91 (🔴 down 2 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: lsviben <sviben.lovro@gmail.com>
@lsviben lsviben force-pushed the fix-line-breaks-lifecycle branch from 95e1dae to 4ce6e48 Compare October 14, 2025 17:58
Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird, there's a bunch of Vale warnings on https://github.com/crossplane/docs/actions/runs/18505575707/job/52733464203?pr=1007 now on lines you didn't touch that do not show up when I run the same vale command with the same vale version locally:

❯ vale --config="utils/vale/.vale.ini" content/master/learn/feature-lifecycle.md
✔ 0 errors, 0 warnings and 0 suggestions in 1 file.

I am not sure what's triggering all these warnings in CI 🤔

@jbw976
Copy link
Member

jbw976 commented Oct 14, 2025

ah, it's for all the old versions - master and 2.0 are OK

Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up @lsviben!

@jbw976 jbw976 merged commit 0b9a3ca into crossplane:master Oct 14, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants